Remove redirect from account verification (to: preserve intent)#13095
Merged
Conversation
Removed the redirect parameter from account login.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the legacy web.py /account/verify flow in openlibrary/plugins/upstream/account.py to stop passing a redirect parameter into the post-verification auto-login, intended to support the “preserve intent” authentication flow.
Changes:
- Removes the
redirectargument from theaccount_login().login(...)call made after successful account verification.
…ropping it The prior fix for the preserve-intent cookie removed *all* redirect forwarding from account_verify.GET(), including a genuine ?redirect= query param, breaking test_valid_token_honors_redirect_param. Only omit redirect when the caller didn't request one, mirroring the existing conditional-kwarg pattern used for issuer_token in InternetArchiveAccount.issue_s3_key.
Member
Author
|
Reviewed w/ @jimchamp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12764
This pull request makes a small change to the
GETmethod inopenlibrary/plugins/upstream/account.py, removing theredirectparameter from theaccount_login().logincall. This simplifies the login flow by no longer specifying a redirect after login.Fixed preserve intent which requires no redirect to be present.