Fix #7388: use ungettext() for rating pluralization in star rating macros

[Entropy-rgb]

Replace manual singular/plural selection with ungettext('rating', 'ratings', ratings_count) in openlibrary/macros/StarRatingsByline.html and openlibrary/macros/StarRatingsComponent.html to support locale-aware plural forms.

Closes #7388

fix

Technical

Replaced manual singular/plural branching with ungettext() so that plural forms are handled correctly across all locales, not just English. The count is now embedded inside the ungettext string in StarRatingsComponent.html as required by the i18n guide. Removed unused ratings_label variable from StarRatingsByline.html.

Testing

• A book with 1 rating displays "1 rating" (singular)
• A book with multiple ratings displays "N ratings" (plural)
• Checked trending.html — no rating pluralization logic present there, no changes needed

Screenshot

Stakeholders

@cdrini

[mekarpeles]

Thank you @Entropy-rgb for this contribution — and welcome to Open Library! 🎉

🤖 Copilot has been assigned for an initial review.

@cdrini is assigned to this PR and currently has:

• 5 open PR(s) of equal or higher priority to review first

Possible improvements for this PR

• Testing section is empty — please add a brief note describing how you tested this change (e.g., confirming that a book page with 1 rating shows "1 rating" and multiple ratings show "N ratings" in the browser). A short description helps reviewers reproduce your verification steps. See Testing & Tools for guidance.
• Pre-commit.ci auto-fix commit in history — there's a [pre-commit.ci] auto fixes commit on this branch. Consider squashing it into the main commit before merge (see the git cheatsheet).

PR triage checklist (maintainers / Richy)

• PR description — not empty; explains what the change does and how to verify it
• References an issue — PR body contains a #NNN reference
  • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
  • Linked issue is assigned — has at least one assignee
• Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
• CI passing — no failing check-runs
• Test cases present — if the change touches substantive logic, test coverage exists or is explained
• Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Richy, via PAM, Open Library's Project AI Manager, on behalf of @mekarpeles. Richy is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

[Copilot]

Pull request overview

Updates star rating macros to use locale-aware pluralization for the “rating/ratings” label by switching to ungettext(...), and refreshes the translation template accordingly.

Changes:

• Replaced manual singular/plural branching with ungettext('rating', 'ratings', ratings_count) in star rating macros.
• Updated messages.pot to represent “rating” as a pluralizable message (msgid/msgid_plural).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
openlibrary/macros/StarRatingsComponent.html	Uses ungettext for the ratings label to support locale plural rules.
openlibrary/macros/StarRatingsByline.html	Uses ungettext for the ratings label (but currently needs a None-safe count).
openlibrary/i18n/messages.pot	Converts “rating/ratings” into a plural-form entry in the POT.

[cdrini]

Nice great start @Entropy-rgb ! Two changes for you.

Also could you take a look at the issue in trending.html listed here? #7388 (comment) . Is this still an issue?

[Entropy-rgb]

Checked trending.html — it doesn't contain any rating pluralization logic, so no changes needed there.
Also rest I'll make the required changes in 2 minutes

[cdrini]

Looking good! One small fix, and then will give this a test later today.

[cdrini]

Made a few more tweaks. Working great now!

Before:

After: