Skip to content

fix: star ratings hidden on Already Read page at mobile/narrow viewports#12798

Merged
mekarpeles merged 1 commit into
internetarchive:masterfrom
Armansiddiqui9:fix/star-ratings-hidden-below-960px
May 28, 2026
Merged

fix: star ratings hidden on Already Read page at mobile/narrow viewports#12798
mekarpeles merged 1 commit into
internetarchive:masterfrom
Armansiddiqui9:fix/star-ratings-hidden-below-960px

Conversation

@Armansiddiqui9

@Armansiddiqui9 Armansiddiqui9 commented May 23, 2026

Copy link
Copy Markdown
Contributor

Closes #12796

fix

Bonus

Star ratings are now also accessible on mobile devices for the first time.
Previously patrons on phones could never rate books directly from their
reading log. This fix unblocks that use case at no extra cost.

Technical

Scope the rule to .read-options and .btn-notice — the containers
that wrap the form exclusively on book detail pages:

.read-options .star-rating-form.desktop,
.btn-notice .star-rating-form.desktop,
.modal-links.desktop {
  display: none;
}

The reading log renders its form inside .list-books, which is never
matched, so ratings now stay visible at all viewport widths.

Testing

  1. Log in and go to /account/books/already-read
  2. Open DevTools → set viewport to 800px or 960px
  3. Before: star widgets invisible
  4. After: star widgets visible and functional

Screenshot

Before
Screenshot 2026-05-24 025955
After
Screenshot 2026-05-24 030013

Mobile view before
Screenshot 2026-05-24 030448
Mobile view After
Screenshot 2026-05-24 030458

Stakeholders

@cdrini @lokesh

@mekarpeles

Copy link
Copy Markdown
Member

Thanks for the PR, @Armansiddiqui9.

🤖 Copilot has been assigned for an initial review.

The linked issue #12796 hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 71 open non-draft PRs ahead of yours.

PR triage checklist (maintainers / Pam)
  • PR description — not empty; explains what the change does and how to verify it
  • References an issue — PR body contains a #NNN reference
    • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned — has at least one assignee
  • Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing — no failing check-runs
  • Test cases present — if the change touches substantive logic, test coverage exists or is explained
  • Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a responsive CSS regression where star rating widgets on the Reading Log “Already Read” page were being hidden at narrow/mobile viewports due to an overly broad selector in the read panel styles.

Changes:

  • Scoped the mobile rule that hides the desktop star rating form so it only applies within book detail page containers (.read-options / .btn-notice), rather than globally.
  • Preserved existing behavior of hiding .modal-links.desktop on mobile to ensure the mobile modal-links variant is used.

@mekarpeles mekarpeles self-assigned this May 26, 2026
@mekarpeles mekarpeles merged commit 3d2f3c8 into internetarchive:master May 28, 2026
8 checks passed
@mekarpeles

Copy link
Copy Markdown
Member

Nice job! Thank you @Armansiddiqui9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can no longer see/set rating from my "Already Read" page

3 participants