Add solr replica to ol-solr2#12706
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Solr replica node (ol-solr2) by enabling Solr replication in the shared Solr config and wiring up production compose + deployment/monitoring scripts to recognize and monitor the new host.
Changes:
- Enable Solr leader/follower replication via a new
/replicationrequest handler insolrconfig.xml. - Add a production
solr_replicaservice/profile (ol-solr2) and markol-solr0as the replication leader. - Update deployment host lists and monitoring to include
ol-solr2.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/solr_builder/dump-solr.sh | Adjusts ia upload CLI flags for Solr dump upload. |
| scripts/monitoring/monitor.py | Adds ol-solr2 to Solr monitoring and maps server→container names. |
| scripts/deployment/deploy.sh | Includes ol-solr2 in the cluster host list for deploy operations. |
| conf/solr/conf/solrconfig.xml | Adds Solr replication request handler with leader/follower configuration. |
| compose.production.yaml | Marks ol-solr0 as replication leader, adds solr_replica profile for ol-solr2, and enables monitoring profile on ol-solr2. |
8959ad5 to
b6c72ae
Compare
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: Drini Cami <[email protected]>
for more information, see https://pre-commit.ci
Member
|
Don't love the "near" compose (would prefer Otherwise LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12583
We want to set up a new solr instance on ol-solr2 that is a replica of ol-solr0. We currently have our ol-solr0 and ol-solr1 on the same baremetal, and it is causing CPU strain. solr2 is on another baremetal, so switching our split to be there should help reduce CPU load across the entire site. This will also let us return to using solr1 for staging instead of a manual replica of prod.
Technical
Need special deploy:
Testing
Screenshot
Stakeholders