make betterworldbooks async#12404
Merged
Merged
Conversation
4 tasks
cdrini
approved these changes
Apr 18, 2026
cdrini
left a comment
Collaborator
There was a problem hiding this comment.
Lgtm, tested on testing and saw BWB prices in the prices panel
|
|
||
|
|
||
| def _get_betterworldbooks_metadata( | ||
| get_betterworldbooks_metadata = async_bridge.wrap(get_betterworldbooks_metadata_async) |
Collaborator
There was a problem hiding this comment.
It might be worthwhile migrating the /prices endpoint to fastapi! It's a tiny one used mainly internally, and will let us delete the bridge/sync version entirely!
shoaib-inamdar
added a commit
to shoaib-inamdar/openlibrary
that referenced
this pull request
Apr 25, 2026
- Add async GET /prices.json endpoint to openlibrary/fastapi/internal/api.py - Uses get_betterworldbooks_metadata_async directly (no sync bridge needed) - Falls back from ISBN-10 to ISBN-13 when BWB returns no price - Add PriceResponse Pydantic model for schema documentation - Mark legacy web.py price_api class as @deprecated('migrated to fastapi') - Add 4 tests in openlibrary/tests/fastapi/test_price.py covering: missing params, isbn lookup, asin lookup, isbn-10 fallback to isbn-13 Part of internetarchive#11999 Pre-work: internetarchive#12404 (make betterworldbooks async)
IvanPisquiy06
pushed a commit
to IvanPisquiy06/openlibrary
that referenced
this pull request
Apr 27, 2026
* make betterworld books async
IvanPisquiy06
pushed a commit
to IvanPisquiy06/openlibrary
that referenced
this pull request
Apr 27, 2026
* make betterworld books async
Sadashii
pushed a commit
to Sadashii/openlibrary
that referenced
this pull request
May 11, 2026
* make betterworld books async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12254
Technical
Testing
Make sure prices are the same both on the html page and the prices api for testing and production:
Screenshot
Stakeholders