Refactoring of DisplayPluginUpdates#887
Merged
slawekjaranowski merged 1 commit intoJan 7, 2023
Merged
Conversation
f9197bc to
a3a1601
Compare
a3a1601 to
1a22976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a (quite) sizeable refactoring job of DisplayPluginUpdates. It already includes #886 as I was doing this while getting to the root cause of #550. In any case, I appreciate that this is a large PR and takes time to analyse.
The goal was to make the class easier to read and understand: after all, the logic is not that complex, it's just the sheer size of it which makes it cumbersome to analyse.